VendorId should be a String #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7597ded | 289.60 ms | 339.69 ms | 50.09 ms |
| 90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
| f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7597ded | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| 90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
| f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
Previous results on branch: fix/vendor-id
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a71440b | 364.43 ms | 414.54 ms | 50.11 ms |
| cf24825 | 349.34 ms | 390.02 ms | 40.68 ms |
| cc533e1 | 319.79 ms | 360.70 ms | 40.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a71440b | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| cf24825 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
| cc533e1 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
|
I'm fine with the breaking change not being in major, @marandaneto what do you say? |
romtsn
approved these changes
Nov 8, 2022
marandaneto
reviewed
Nov 8, 2022
Co-authored-by: Manoel Aranda Neto <[email protected]>
I like the idea:
But I dont think anyone is using it directly, Dart has no overloads, so I considered a bug fix because right now it does not work anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
gpu.vendorIdwas defined as an Int, should be a String.💡 Motivation and Context
This is a breaking change but I'm wondering if anyone is using it. We could introduce a
@Deprecated void setVendorId(int vendorId) { setVendorId(String.valueOf(vendorId)); }to minimize the impact, but I'm not sure if it's worth it.Mobile Issue: getsentry/team-mobile#67
Dart: getsentry/sentry-dart#1112
💚 How did you test it?
📝 Checklist
🔮 Next steps